Skip to content

Feature/ecs0001 prefer implicitly typed local variables #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rjmurillo
Copy link
Owner

@rjmurillo rjmurillo commented Jul 26, 2024

Add support for Item 1 from Effective C#: Use var to declare local variables for better readability and efficiency, except for built-in numeric types where explicit typing prevents potential conversion issues.

Resolves BillWagner/EffectiveCSharpAnalyzers#1

@rjmurillo rjmurillo changed the title Feature/ecs0001 prefer implicitly typed local varaibles Feature/ecs0001 prefer implicitly typed local variables Jul 26, 2024
@rjmurillo rjmurillo added documentation Improvements or additions to documentation analyzers releasable feature labels Jul 26, 2024
Copy link

codacy-production bot commented Jul 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+3.88% (target: -1.00%) 93.15%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e7c151c) 283 210 74.20%
Head commit (5fe2157) 356 (+73) 278 (+68) 78.09% (+3.88%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21) 73 68 93.15%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@rjmurillo rjmurillo marked this pull request as ready for review July 26, 2024 03:54
@rjmurillo rjmurillo added this to the vNext milestone Jul 26, 2024
@rjmurillo rjmurillo enabled auto-merge (squash) July 26, 2024 03:54
@rjmurillo rjmurillo merged commit 097a362 into main Jul 26, 2024
8 checks passed
@rjmurillo rjmurillo deleted the feature/ecs0001-prefer-implicitly-typed-local-varaibles branch July 26, 2024 03:58
@rjmurillo rjmurillo linked an issue Jul 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzers documentation Improvements or additions to documentation releasable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

01 Prefer Implicitly Typed Local Variables Item 1: Prefer Implicitly Typed Local Variables
1 participant